Amar3tto commented on PR #40164: URL: https://github.com/apache/beam/pull/40164#issuecomment-5887935014
Thanks for working on this! I think this change is a useful incremental improvement - collecting all .exec files from the current project's build/jacoco directory allows coverage from additional test tasks such as `needsRunnerTests` and `validatesRunner` to be included, and the change looks low-risk. One thing: I don't think this fully addresses #18194, since coverage generated by tests running in another Gradle project (for example SDK Core tests executed from a runner project) still won't be included in the SDK project's report. I'm fine with merging this improvement, but I suggest we don't close #18194 and describe this PR as a partial fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
