anishmehta24 commented on code in PR #40165: URL: https://github.com/apache/beam/pull/40165#discussion_r4138488490
########## sdks/python/apache_beam/metrics/metrics_flag.py: ########## @@ -0,0 +1,103 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Process-wide switches that stop kinds of user metrics from being reported. + +This module is imported by ``apache_beam.metrics.execution`` and by the +pipeline and worker start-up code, so it deliberately keeps its imports to a +minimum to avoid circular imports. +""" + +# pytype: skip-file + +import logging +from typing import TYPE_CHECKING +from typing import Any +from typing import Set + +from apache_beam.metrics import cells Review Comment: Done. metrics_flag no longer imports cells: the set holds cell type names, the *_disabled checks look up the name, and MetricUpdater compares cell_type.__name__ (only when something is disabled). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
