schizophrenicmaniac opened a new pull request, #40380:
URL: https://github.com/apache/beam/pull/40380
`ParDo._get_key_and_window_coder` picked the main input with
`set(named_inputs.keys()) - set(self.side_inputs)`. The keys are tag strings
and `self.side_inputs` holds `_SideInput` objects, so nothing was ever removed.
Which tag came out first depended on set ordering, and so on the hash seed.
When it was a `python_side_input*` tag, the timer family coder got the side
input's key coder, or `FastPrimitivesCoder` if the side input was `Any`. On
Dataflow that shows up as `ValueError: Unknown type tag` when the worker
decodes timer keys.
This takes the first tag that doesn't start with `SIDE_INPUT_PREFIX`
instead. I went with the tag rather than comparing PCollections so it still
works when the main input PCollection is also passed as a side input.
The new test in `userstate_test.py` uses a stateful DoFn with three dict
side inputs keyed by ints and checks that the timer key coder in the proto is
the main input's `StrUtf8Coder`. Without the fix it failed for 22 of 32 hash
seeds locally; with it, none.
Fixes #40374
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
