anishmehta24 commented on code in PR #40399:
URL: https://github.com/apache/beam/pull/40399#discussion_r4188586703
##########
sdks/python/apache_beam/transforms/util.py:
##########
@@ -2234,8 +2234,8 @@ def find_all(pcoll, regex, group=0, outputEmpty=True):
def _process(element):
matches = regex.finditer(element)
if group == Regex.ALL:
- yield [(m.group(), m.groups()[0]) for m in matches
- if outputEmpty or m.groups()[0]]
+ yield [(m.group(), *m.groups()) for m in matches
+ if outputEmpty or any(m.groups() or (m.group(), ))]
Review Comment:
Done: it gates on the full match now, the docstring says so,
`CheckAllNonEmptyGroups` keeps `('a', '')`, and there's a Breaking Changes
entry under 2.78.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
