Ayoubhm07 opened a new pull request, #40430: URL: https://github.com/apache/beam/pull/40430
`_CustomBigQueryStorageSource._setup_temporary_dataset` logs the dataset labels at warning level, right before passing the same value to `create_temporary_dataset` : https://github.com/apache/beam/blob/c74609d71eeae8127cd8fa6b1c06a2c9e92422a5/sdks/python/apache_beam/io/gcp/bigquery.py#L1152 Three things suggest a debug print rather than an intended log line : - `###` appears in no other logging call under `sdks/python/apache_beam`, across its 1380 `.py` files - `str()` is redundant with `%s` - it is the only `_LOGGER.warning(...)` call in the module, and it reports a value the caller supplied in the first place `git blame` puts the line in #15602, which added the BigQuery Read API support in October 2021, and it has not changed since No test refers to it : the only `assertLogs` in `io/gcp` is `bigquery_test.py:398`, which targets a DEBUG message from `bigquery_read_internal` on an unrelated path `_LOGGER` is still used at nine call sites in the module, so nothing becomes unused Checked with `yapf==0.43.0`, the version pinned in `tox.ini:294` : no diff If you would rather keep the value visible, I am happy to demote it to `debug` instead of removing it ------------------------ - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. - not applicable, no issue filed for a one-line log removal - [ ] Update `CHANGES.md` with noteworthy changes. - not noteworthy, removing a debug log changes no behaviour and no API - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement. - one line removed, no ICLA needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
