reuvenlax commented on PR #40428: URL: https://github.com/apache/beam/pull/40428#issuecomment-6024109487
But Flink is fine with the changes. Unless another runner is also failing, I would leave the default as it is. We definitely don't want to rollback DirectRunner, as Java PreSubmit has historically been slow. On Tue, Oct 6, 2026 at 12:31 PM Tobias Kaymak ***@***.***> wrote: > *tkaymak* left a comment (apache/beam#40428) > <https://github.com/apache/beam/pull/40428#issuecomment-6023933561> > > Done, beam.validatesRunner.parallelThreads now defaults to 1 in > BeamParallelJunit4Runner independent of beam.test.parallelThreads, > Dataflow keeps its explicit value and the Spark gradle changes are > reverted. One place this reaches beyond Spark is > :runners:direct-java:needsRunnerTests in PreCommit Java, where the > ValidatesRunner methods ran 8 wide since #40324 > <https://github.com/apache/beam/pull/40324>, so I set 8 there and in the > Direct validatesRunner task to keep the PreSubmit speedup, happy to drop > it if you prefer Dataflow only. The 8 Spark PostCommits rerun on this push, > the Direct VR trigger file is bumped as well. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/40428?email_source=notifications&email_token=AFAYJVOOD3AV2VTEO5ICXT35SVCC5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBSGM4TGMZVGYY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6023933561>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFAYJVN4XQYJ6XLTWSUXCMT5SVCC5AVCNFSNUABEKJSXA33TNF2G64TZHM2TAOJQGQZDINJ3JFZXG5LFHM2TOMRWGI3DIMJXGWQXMAQ> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/AFAYJVNLFTQ64X4YRIZXKYL5SVCC5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBSGM4TGMZVGYY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/AFAYJVMILUJDHTHZNFQHZMT5SVCC5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBSGM4TGMZVGYY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
