vishalmore90 opened a new pull request, #40443:
URL: https://github.com/apache/beam/pull/40443
fixes #40442
### Context
`VertexAIFeatureStoreEnrichmentHandler` is designed to log a warning and
proceed if the user lacks sufficient admin permissions to verify the feature
store's existence during initialization. However, the
`get_feature_online_store` RPC call—which actually performs the permission
check—was placed in the `else` block of the `try...except Exception` structure.
This caused `PermissionDenied` errors to bypass the intended fallback and crash
the pipeline.
### Changes
Moved `get_feature_online_store` and its path resolution methods out of the
`else` block and into the `try` block. This correctly catches exceptions (e.g.,
`PermissionDenied`) thrown during the RPC call and triggers the intended
`_LOGGER.warning` fallback.
### Verification
* [x] Manually inspected the `try...except` control flow.
* [x] Verified Python syntax via `py_compile`.
* [x] Relies on existing GitHub Actions Python Tests workflows to ensure no
regressions in enrichment handler unit tests.
### Checklist
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
