Abacn commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r4213407448
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -689,6 +690,11 @@ class BeamModulePlugin implements Plugin<Project> {
activemq_junit :
"org.apache.activemq.tooling:activemq-junit:$activemq_version",
activemq_kahadb_store :
"org.apache.activemq:activemq-kahadb-store:$activemq_version",
activemq_mqtt :
"org.apache.activemq:activemq-mqtt:$activemq_version",
+ activemq6_amqp :
"org.apache.activemq:activemq-amqp:$activemq6_version",
Review Comment:
if activemq 5 and 6 have same package name, BeamModulePlugin version
resolution doesn't work well as it tries to enforce a version it first see. As
you may have already noticed and added force resolution in io.amqp
Consider simply bump activemq deps to v6 and pin to v5 in activemq, which
has same effect
##########
.github/workflows/beam_PostCommit_Python_Xlang_Messaging_Direct.yml:
##########
@@ -69,6 +69,7 @@ jobs:
- name: Setup environment
uses: ./.github/actions/setup-environment-action
with:
+ java-version: '17'
Review Comment:
We no longer need these lines as the CI is on Java 21 currently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
