schizophrenicmaniac opened a new pull request, #40463:
URL: https://github.com/apache/beam/pull/40463
`VertexAIFeatureStoreEnrichmentHandler.__init__` tries to check that the
feature store exists and is meant to only log a warning if the caller doesn't
have admin permission. But the try/except only covered creating
`FeatureOnlineStoreAdminServiceClient`, which makes no RPC. The call that
actually checks permissions, `get_feature_online_store`, was in the `else`
branch, so a `PermissionDenied` went uncaught and failed pipeline construction
for users who only have data read access.
This moves the path building and `get_feature_online_store` into the try and
catches `PermissionDenied` specifically, so `NotFound` and other errors still
surface. Errors raised while creating the client are no longer turned into the
"insufficient admin permission" warning either. They would fail again in
`__enter__` anyway. Added unit tests that mock the admin client for the
`PermissionDenied` and `NotFound` cases.
Fixes #40442
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
for a list of workflows and how to trigger them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
