kennknowles commented on a change in pull request #12870:
URL: https://github.com/apache/beam/pull/12870#discussion_r501132321
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -151,33 +161,34 @@ def commonExcludeCategories = [
// For the following test tasks using legacy worker, set
workerHarnessContainerImage to empty to
// make Dataflow pick up the non-versioned container image, which handles a
staged worker jar.
-task validatesRunnerLegacyWorkerTest(type: Test) {
- group = "Verification"
- dependsOn
":runners:google-cloud-dataflow-java:worker:legacy-worker:shadowJar"
-
- systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
- "--runner=TestDataflowRunner",
- "--project=${dataflowProject}",
- "--region=${dataflowRegion}",
- "--tempRoot=${dataflowValidatesTempRoot}",
- "--dataflowWorkerJar=${dataflowLegacyWorkerJar}",
- "--workerHarnessContainerImage=",
- ])
-
- // Increase test parallelism up to the number of Gradle workers. By default
this is equal
- // to the number of CPU cores, but can be increased by setting
--max-workers=N.
- maxParallelForks Integer.MAX_VALUE
- classpath = configurations.validatesRunner
- testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs) +
- files(project(project.path).sourceSets.test.output.classesDirs)
- useJUnit {
- includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
- commonExcludeCategories.each {
- excludeCategories it
+def createValidatesRunnerTest = { name, pipelineOptions=legacyPipelineOptions,
disabledTests=[] ->
Review comment:
Agree with your naming point, and pushed a rename.
I believe that is possible to continue to configure with a block but
Groovy's scope configuration blocks confuse the heck out of me so I did not try
to do it. I expect you can do it either by passing the closure in to the
`createValidatesRunner` function or by returning something that is ready to
accept a block. I'm a bit hazy on how/when the latter works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
