AMOOOMA commented on issue #40469: URL: https://github.com/apache/beam/issues/40469#issuecomment-6130307893
I think we might need to make a separate change to support KeyedModelHandler with model manager = True, instead of trying to force it to return all of the model instances because acquiring them takes a lot of time and model instance should be managed by the model manager instead of the handler if it's used so things should be automatically updated by just calling acquire with the new model tag instead of calling all_models and manipulate with the instances. Filed Issue #40539 to track and adding todo to the existing PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
