derrickaw commented on code in PR #40484: URL: https://github.com/apache/beam/pull/40484#discussion_r4253454552
########## sdks/python/apache_beam/yaml/examples/transforms/blueprint/gcs_avro_to_cloud_bigtable.yaml: ########## @@ -0,0 +1,65 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This is an example of a Beam YAML pipeline that reads from GCS Avro files +# and writes to Cloud Bigtable. This matches the Dataflow Template located +# here - https://cloud.google.com/dataflow/docs/guides/templates/provided/avro-to-cloud-bigtable Review Comment: > What is our goal in mirroring all of these across both places? Do we intend to keep them totally in sync? These examples are pending usage examples that I wanted to wrap up soon. Will remove the link to not have coupled so tightly explicitly. Also, its not meant to duplicate all. Just the most popular ones. > It looks like we've been doing this for a while, but this seems like an antipattern to me That link was incorrectly linked and will remove. > Or are we just saying that this has the same functionality as the Java version of this template? Yes, but will remove the link to avoid the confusion. > > Btw, is there a reason we're back to blueprint terminology? That may be what is confusing me ([#39549 (comment)](https://github.com/apache/beam/pull/39549#discussion_r3758220548)) Sorry, I started treating anything that is yaml pipeline (with .yaml) as a blueprint regardless of the user. Let me update that to avoid more confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
