chamikaramj commented on code in PR #40542:
URL: https://github.com/apache/beam/pull/40542#discussion_r4253487268
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/cdc/sink/OrderedCommitFn.java:
##########
@@ -157,7 +157,6 @@ interface Clock extends LongSupplier, Serializable {}
this.pendingSpec = StateSpecs.bag(CommitDeltas.windowedCommitCoder());
}
- @RequiresStableInput
Review Comment:
Could you mention in the PR description why these were removed ? Won't this
change the behavior for non-Dataflow runners ?
##########
sdks/python/apache_beam/yaml/extended_tests/e2e/delta_lake_cdc_to_iceberg.yaml:
##########
@@ -0,0 +1,94 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
Review Comment:
Could you also try these against Dataflow ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
