Abacn commented on code in PR #40551:
URL: https://github.com/apache/beam/pull/40551#discussion_r4259908604
##########
settings.gradle.kts:
##########
@@ -65,20 +64,13 @@ buildCache {
local {
isEnabled = true
}
- remote<HttpBuildCache> {
- url = uri("https://beam-cache.apache.org/cache/";)
- isAllowUntrustedServer = false
- credentials {
- username = System.getenv("GRADLE_ENTERPRISE_CACHE_USERNAME")
- password = System.getenv("GRADLE_ENTERPRISE_CACHE_PASSWORD")
- }
- isEnabled =
!System.getenv("GRADLE_ENTERPRISE_CACHE_USERNAME").isNullOrBlank()
+ remote(develocity.buildCache) {
+ isEnabled = true
Review Comment:
Is `isEnabled = true` intended, or shall we enable remote cache only for
`isCI`?
I see the description,
> Reads: enabled for every build, including pull requests and local builds.
The cache on develocity.apache.org is anonymously readable, so no credentials
are needed.
Previously remote cache isn't enabled in release candidate builds
(https://github.com/apache/beam/blob/master/.github/workflows/build_release_candidate.yml),
as it's supposed to start with a fresh build. We can follow up later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
