jrmccluskey commented on code in PR #40220:
URL: https://github.com/apache/beam/pull/40220#discussion_r4262952914
##########
sdks/python/apache_beam/examples/inference/decision_models/requirements.txt:
##########
@@ -16,4 +16,4 @@
#
# Optional client for apache_beam.ml.inference.typesafe_inference.
-typesafe-sdk>=0.7.1,<0.8
+-r ../../../ml/inference/typesafe_tests_requirements.txt
Review Comment:
It's okay to leave this as a hard-coded package number rather than pointing
to the requirements file, but not a big deal either way
##########
sdks/python/tox.ini:
##########
@@ -121,6 +121,7 @@ commands =
# Don't set TMPDIR to avoid "AF_UNIX path too long" errors in certain tests.
deps =
accelerate>=1.6.0
+ -r{toxinidir}/apache_beam/ml/inference/typesafe_tests_requirements.txt
Review Comment:
I don't love incorporating the test dependency at this level, I'd prefer
this either gets added to the p312_ml_test extras directly if this is the
target python version to support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
