raams95 commented on PR #40548:
URL: https://github.com/apache/beam/pull/40548#issuecomment-6153914680
Thanks, makes sense. I removed the unit test and re-enabled Query 1 in
`beam_PostCommit_Python_Nexmark_Direct.yml`.
I ran the suite locally the same way that workflow does: Java Nexmark
(`:sdks:java:testing:nexmark:run`, DirectRunner, SMOKE, 100,000 events) to
generate the event file, then the Python launcher on it with DirectRunner.
| Query | master | this PR |
|---|---|---|
| 0 | 100000 in, 100000 out | 100000 in, 100000 out |
| 1 | fails | 100000 in, 92000 out |
| 2 | 100000 in, 351 out | 100000 in, 351 out |
On master, Query 1 fails with:
```
TypeError: unsupported operand type(s) for &: 'float' and 'int' [while
running 'ConvertToEuro']
... nexmark_model.py, line 201, in encode_to_stream
self._int_coder_impl.encode_to_stream(value.price, stream, True)
```
One thing I noticed: the Python launcher logs "Discarding unparseable args"
for `--suite=SMOKE`, `--enforce_encodability` and `--enforce_immutability`, so
those flags don't take effect there (same in CI). The failure above happens
anyway, because the coder encodes the bids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
