scwhittle commented on code in PR #40552:
URL: https://github.com/apache/beam/pull/40552#discussion_r4268337919
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java:
##########
@@ -2132,17 +2045,12 @@ public ReadChangeStream
withDatabaseId(ValueProvider<String> databaseId) {
return withSpannerConfig(config.withDatabaseId(databaseId));
}
- /** Specifies whether OpenTelemetry tracing is enabled. */
+ /**
+ * Specifies whether OpenTelemetry tracing should start trace and span on
each change record.
+ * For Spanner Client library tracing config, use SpannerConfig
(withSpannerConfig).
+ */
public ReadChangeStream withEnableOpenTelemetryTracing(boolean
enableOpenTelemetryTracing) {
Review Comment:
I think withOpenTelemetryTracing() would read better as builder
`withDatabaseId(blah).withOpenTelemetryTracing()`
But also maybe this should be a little clearer on the tracing it enables,
withPerChangeRecordOpenTelementryTracing()
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java:
##########
@@ -2132,17 +2045,12 @@ public ReadChangeStream
withDatabaseId(ValueProvider<String> databaseId) {
return withSpannerConfig(config.withDatabaseId(databaseId));
}
- /** Specifies whether OpenTelemetry tracing is enabled. */
+ /**
+ * Specifies whether OpenTelemetry tracing should start trace and span on
each change record.
+ * For Spanner Client library tracing config, use SpannerConfig
(withSpannerConfig).
Review Comment:
how about
Spanner Client library tracing can be enabled via the SpannerConfig passed
to withSpannerConfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
