schizophrenicmaniac commented on PR #40500: URL: https://github.com/apache/beam/pull/40500#issuecomment-6180445904
@shunping The lock there was created fresh on each call (`lock = threading.Lock()` right before `acquire`), so it always succeeded and never actually protected anything. You're right that the state needs guarding though, since the shared manager handles calls from different processes on separate threads. I've added a lock on `_ModelHandlerManager` itself that covers the process id check and the `_max_models` update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
