lukecwik commented on a change in pull request #13025: URL: https://github.com/apache/beam/pull/13025#discussion_r501348572
########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/testing/RunnerV2Incompatible.java ########## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.testing; + +import org.apache.beam.sdk.annotations.Internal; + +/** Category tag for sick-baying validation tests which are incompatible with Dataflow Runner V2. */ +@Internal +public interface RunnerV2Incompatible {} Review comment: DataflowRunnerV2Incompatible? ########## File path: runners/google-cloud-dataflow-java/build.gradle ########## @@ -227,6 +227,34 @@ task validatesRunner { dependsOn validatesRunnerLegacyWorkerTest } +task validatesRunnerV2Test(type: Test) { + group = "Verification" + dependsOn buildAndPushDockerContainer + + systemProperty "beamTestPipelineOptions", JsonOutput.toJson([ + "--runner=TestDataflowRunner", + "--project=${dataflowProject}", + "--region=${dataflowRegion}", + "--tempRoot=${dataflowValidatesTempRoot}", + "--workerHarnessContainerImage=${dockerImageContainer}:${dockerTag}", + "--experiments=beam_fn_api,use_unified_worker", + ]) + + // Increase test parallelism up to the number of Gradle workers. By default this is equal + // to the number of CPU cores, but can be increased by setting --max-workers=N. + maxParallelForks Integer.MAX_VALUE + classpath = configurations.validatesRunner + testClassesDirs = files(project(":sdks:java:core").sourceSets.test.output.classesDirs) + + files(project(project.path).sourceSets.test.output.classesDirs) + useJUnit { + includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner' + excludeCategories 'org.apache.beam.sdk.testing.RunnerV2Incompatible' + commonExcludeCategories.each { Review comment: Dataflow Runner V2 supports several items in the commonExcludeCategories like map state, bundle finalizer, test stream. Please only exclude tests that are excluded within google. ########## File path: .test-infra/jenkins/job_PostCommit_Java_ValidatesRunner_Dataflow_V2.groovy ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import CommonJobProperties as commonJobProperties +import PostcommitJobBuilder + + +// This job runs the suite of ValidatesRunner tests against the Dataflow +// runner V2. +PostcommitJobBuilder.postCommitJob('beam_PostCommit_Java_ValidatesRunner_Dataflow_V2', + 'Run Dataflow_V2 ValidatesRunner', 'Google Cloud Dataflow Runner V2 ValidatesRunner Tests', this) { Review comment: Is the purpose of this job jenkins job to run Java, Go and Python ValidatesRunner tests, it not we should include Java in the name somewhere. nit: Dataflow_V2 -> DataflowV2 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
