Abacn commented on code in PR #39663:
URL: https://github.com/apache/beam/pull/39663#discussion_r4284914569
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java:
##########
@@ -437,6 +437,9 @@ private BeamFnApi.ProcessBundleDescriptor
loadDescriptor(String id) {
beamFnStatusClient.close();
}
processBundleHandler.shutdown();
+ beamFnDataMultiplexer.close();
Review Comment:
processBundleHandler.shutdown() already calls
`beamFnStateGrpcClientCache.close();` and ` beamFnDataClient.close();`
This is redundant though probably harmless, however we should close client
in the place where it owns it in general, to avoid potential pre-mature channel
break
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
