tvalentyn commented on code in PR #40598:
URL: https://github.com/apache/beam/pull/40598#discussion_r4285542909
##########
sdks/python/apache_beam/io/components/adaptive_throttler.py:
##########
@@ -155,16 +165,18 @@ def __init__(
Args:
window_ms: int, length of history to consider, in ms, to set
- throttling.
+ throttling. Should be much larger than throttle_delay_secs and any
+ retry backoff between attempts, otherwise failures expire from the
+ history before they can influence throttling.
Review Comment:
removing "and the retry backoff," sgtm.
I am not sure how throttling and exponential backoff are expected to coexist
- should we only use one of these mechanisms? I haven't looked into best
practices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
