darshan-sj commented on code in PR #40489:
URL: https://github.com/apache/beam/pull/40489#discussion_r4286499234
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java:
##########
@@ -117,6 +117,10 @@ public String getHostValue() {
public abstract @Nullable ValueProvider<Boolean>
getEnableOpenTelemetryTracing();
+ public abstract @Nullable ValueProvider<Boolean>
getExcludeTxnFromChangeStreams();
+
+ public abstract @Nullable ValueProvider<String> getTransactionTag();
Review Comment:
Did you mean --
https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/d5fad984ef476277fb19e0dbbcfd91cdb2d4566a/v1/src/main/java/com/google/cloud/teleport/spanner/spannerio/SpannerConfig.java#L93
??
The template for which this change is made is `SourceDbToSpanner` and that
does not use the local copy of the SpannerIO. But we still need to keep these
two copies in sync. I will raise a separate PR in DataflowTemplates repository
importing all the new changes from Beam's SpannerIO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
