github-actions[bot] commented on code in PR #40508:
URL: https://github.com/apache/beam/pull/40508#discussion_r4301620936
##########
local-env-setup.sh:
##########
@@ -68,6 +68,13 @@ if [ "$kernelname" = "Linux" ]; then
exit
fi
+ type -P rustc > /dev/null 2>&1
+ rustExists=$?
+ if [ $rustExists -ne 0 ]; then
+ echo "Installing rust via rustup..."
+ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
+ fi
Review Comment:
**🟡 Medium**: `protoc` is installed on macOS below (lines 163–170), and the
PR description notes that `local-env-setup.sh` installs Rust and `protoc`.
However, on Linux neither `local-env-setup.sh` nor `dev-support/docker/pkglist`
installs `protobuf-compiler`, which is required by `tonic-prost-build` in
`beam/model/build.rs`. Consider ensuring `protoc` (`protobuf-compiler`) is also
installed in the Linux setup path (or added to `dev-support/docker/pkglist`).
##########
release/src/main/scripts/set_version.sh:
##########
@@ -115,4 +118,5 @@ if [[ "$GIT_ADD" == yes ]] ; then
git add runners/google-cloud-dataflow-java/build.gradle
git add sdks/typescript/package.json
git add scripts/beam-sql.sh
+ git add 'sdks/rust/*Cargo.toml' sdks/rust/Cargo.lock
Review Comment:
**🟠High**: In Git pathspecs, a quoted `sdks/rust/*Cargo.toml` without
`:(glob)` matches `*` across slashes, or if expanded by the shell when
unquoted, only matches a single directory level (`sdks/rust/Cargo.toml`).
However, to be unambiguous and idiomatic with Git pathspecs for recursive
matching (such as `sdks/rust/beam/model/Cargo.toml`), use
`sdks/rust/**/Cargo.toml` or include `sdks/rust/Cargo.toml` explicitly
alongside recursive globs.
```suggestion
git add 'sdks/rust/**/Cargo.toml' sdks/rust/Cargo.toml sdks/rust/Cargo.lock
```
##########
sdks/rust/README.md:
##########
@@ -0,0 +1,49 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Rust SDK
+
+A library for writing [Apache Beam](https://beam.apache.org/) pipelines in
Rust.
+
+The SDK is under active development. [DESIGN.md](DESIGN.md) describes its
design.
Review Comment:
**🟢 Low**: `DESIGN.md` does not exist in `sdks/rust/` in this PR, resulting
in a broken link. If `DESIGN.md` is being added in a subsequent PR, consider
either removing this link for now or linking to the design doc/RFC URL until
the file is added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
