scwhittle commented on code in PR #40593:
URL: https://github.com/apache/beam/pull/40593#discussion_r4311524848
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/BoundedQueueExecutor.java:
##########
@@ -528,6 +531,12 @@ BoundedQueueExecutorWorkHandleImpl createBudgetHandle(Work
work, long bytes) {
/**
* Purges stale shells in bulk if they accumulate while all executor threads
are busy running
* multi-key bundles.
+ *
+ * <p>{@code forceExecute} can queue more than {@code
maximumElementsOutstanding} unstarted items
+ * (e.g. retries or finalizations). {@code elementsOutstanding} counts
non-shell work items, so
+ * comparing {@code workQueue.size()} against {@code elementsOutstanding +
+ * maximumElementsOutstanding} allows up to {@code
maximumElementsOutstanding} closed stale shells
Review Comment:
nit: s/allows up to/means there is at least/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
