alisha-1000 commented on issue #40644: URL: https://github.com/apache/beam/issues/40644#issuecomment-6312421036
Hi! @tvalentyn @Eliaaazzz I've implemented the argument validation and added unit tests for the relevant cases. The `ModelHandlerBatchingArgsTest` suite passes (17 tests). I wanted to confirm one detail before finalizing: should `max_batch_weight` be rejected when either `batch_length_fn` or `batch_bucket_boundaries` is provided, or should any of these combinations remain supported? I want to ensure the validation matches the intended behavior. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
