github-actions[bot] commented on code in PR #40758:
URL: https://github.com/apache/beam/pull/40758#discussion_r4364370091
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CreateTest.java:
##########
@@ -134,16 +134,16 @@ public void testCreateEmptyIterableWithCoder() {
p.run();
}
- static class Record implements Serializable {}
+ static class TestRecord implements Serializable {}
- static class Record2 extends Record {}
+ static class TestRecord2 extends TestRecord {}
- private static class RecordCoder extends AtomicCoder<Record> {
+ private static class TestRecordCoder extends AtomicCoder<TestRecord> {
@Override
- public void encode(Record value, OutputStream outStream) throws
CoderException, IOException {}
+ public void encode(TestRecord value, OutputStream outStream) throws
CoderException, IOException {}
Review Comment:
**🟡 Medium**: This line is now 102 characters long, and lines 466 (109
chars) and 482 (101 chars) also exceed the 100-character limit enforced by
Spotless. Please run `./gradlew :sdks:java:core:spotlessApply` to format these
lines.
##########
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/CloudObjectsTest.java:
##########
@@ -286,13 +286,13 @@ public int hashCode() {
}
/** A non-custom coder with no registered translator. */
- private static class ArbitraryCoder extends StructuredCoder<Record> {
+ private static class ArbitraryCoder extends StructuredCoder<TestRecord> {
@Override
- public void encode(Record value, OutputStream outStream) throws
CoderException, IOException {}
+ public void encode(TestRecord value, OutputStream outStream) throws
CoderException, IOException {}
Review Comment:
**🟡 Medium**: Renaming `Record` to `TestRecord` pushes this line to 102
characters, exceeding the 100-column limit enforced by Spotless
(`google-java-format`). Please wrap the `throws` clause or run `./gradlew
:runners:google-cloud-dataflow-java:spotlessApply`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
