mxtymoshyk commented on PR #40790: URL: https://github.com/apache/beam/pull/40790#issuecomment-6399400055
Re the automated review's `TableDestination.equals`/`hashCode` finding: Clustering has been left out of `equals`/`hashCode` since it was added in BEAM-5191 (2018), so this predates the PR. Range partitioning follows the same pattern as time partitioning. The `TableDestination` coders don't override `consistentWithEquals()`, so Beam groups by encoded bytes, which already include clustering. I'd rather not change grouping for existing clustering users in this PR. I can open a follow-up issue if reviewers want it changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
