github-actions[bot] commented on code in PR #40823:
URL: https://github.com/apache/beam/pull/40823#discussion_r4381876142
##########
sdks/python/pyproject.toml:
##########
@@ -31,7 +31,8 @@ requires = [
# Avoid https://github.com/pypa/virtualenv/issues/2006
"distlib==0.4.4",
# Numpy headers
- "numpy>=1.23.2,<2.6.0", # Update setup.py as well.
+ "numpy>=1.23.2,<2.6.0"; python_version >= '3.12'", # Update setup.py as
well.
Review Comment:
**🔴 Critical**: There is a stray `"` before `; python_version`, which
terminates the TOML string early and causes a TOML parse error when building
the package.
```suggestion
"numpy>=1.23.2,<2.6.0; python_version >= '3.12'", # Update setup.py as
well.
```
##########
sdks/python/pyproject.toml:
##########
@@ -31,7 +31,8 @@ requires = [
# Avoid https://github.com/pypa/virtualenv/issues/2006
"distlib==0.4.4",
# Numpy headers
- "numpy>=1.23.2,<2.6.0", # Update setup.py as well.
+ "numpy>=1.23.2,<2.6.0"; python_version >= '3.12'", # Update setup.py as
well.
+ "numpy>=1.23.2,<2.5.0"; python_version < '3.12'",
Review Comment:
**🔴 Critical**: There is a stray `"` before `; python_version`, which
results in invalid TOML syntax.
```suggestion
"numpy>=1.23.2,<2.5.0; python_version < '3.12'",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
