prodriguezdefino commented on code in PR #40508:
URL: https://github.com/apache/beam/pull/40508#discussion_r4385012704
##########
local-env-setup.sh:
##########
@@ -68,6 +68,13 @@ if [ "$kernelname" = "Linux" ]; then
exit
fi
+ type -P rustc > /dev/null 2>&1
+ rustExists=$?
+ if [ $rustExists -ne 0 ]; then
+ echo "Installing rust via rustup..."
+ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
Review Comment:
Nothing later in `local-env-setup.sh` invokes `cargo` or `rustc` in this PR
(line 75 is the end of the Linux block), and because `local-env-setup.sh` is
executed as a child process rather than sourced, sourcing `$HOME/.cargo/env`
here wouldn't export `PATH` to the caller's interactive shell anyway (same as
`GOPATH` on line 32).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
