acrites commented on code in PR #40639:
URL: https://github.com/apache/beam/pull/40639#discussion_r4394654888
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFn.java:
##########
@@ -112,7 +111,7 @@ protected void onStartKey() {
// These elements are now processed. Register cleanup timers
for all the unblocked
// windows.
helpers.registerStateCleanup(
- (WindowingStrategy<?, W>)
getDoFnInfo().getWindowingStrategy(),
+ (WindowingStrategy<?, W>)
helpers.fnInfo.getWindowingStrategy(),
Review Comment:
Note I changed these to call `helpers.fnInfo` directly since `getDoFnInfo()`
now potentially throws `Exception` (from `helpers.doFnInstanceManager.peek()`).
There were already instances of calling `helpers.fnInfo` in this method so this
seemed cleaner than adding more exception throwing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
