shunping commented on code in PR #40855:
URL: https://github.com/apache/beam/pull/40855#discussion_r4404690761
##########
sdks/python/apache_beam/ml/inference/base_test.py:
##########
@@ -3153,5 +3154,27 @@ def
test_run_inference_dofn_model_update_acquires_and_releases_matching_tag(
dofn._model.force_reset()
+class ResourceImportTest(unittest.TestCase):
Review Comment:
I think the test is trivial and I would just remove that.
Instead, have you considered adding a unit test to `RunInference` to see if
we will get warnings if ModelMananger is not importable but resource is?
If it is doable and the test is simple (without using subprocess), I would
rather have that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
