github-actions[bot] commented on code in PR #40883: URL: https://github.com/apache/beam/pull/40883#discussion_r4413343555
########## sdks/python/container/ml/py312/gpu_image_requirements.txt: ########## @@ -317,7 +317,7 @@ urllib3==2.7.0 uvicorn==0.52.3 uvloop==0.22.1 virtualenv-clone==0.5.7 -vllm==0.10.1.1 +vllm==0.32.0 Review Comment: **🔴 Critical**: Bumping `vllm` to `0.32.0` in isolation breaks this pinned requirements file: 1. **Incompatible pinned dependencies in this file:** `vllm==0.32.0` requires `torch==2.13.0` (pinned to `2.7.1`), `torchaudio==2.11.0` (pinned to `2.7.1`), `torchvision==0.28.0` (pinned to `0.22.1`), `transformers>=5.16.1,<5.20.0` (pinned to `4.55.4`), `tokenizers>=0.23.2` (pinned to `0.21.4`), `huggingface_hub>=1.31.0` (pinned to `0.36.2`), `openai>=2.25.0` (pinned to `1.107.1`), `fastapi[standard]>=0.133.0,<0.137.0` (pinned to `0.141.1`), `compressed-tensors==0.17.0` (pinned to `0.10.2`), `depyf==0.20.0` (pinned to `0.19.0`), `lm-format-enforcer==0.11.3` (pinned to `0.10.12`), `llguidance>=1.7.0,<1.8.0` (pinned to `0.7.30`), `numba==0.65.0` (pinned to `0.61.2`), `outlines_core==0.2.14` (pinned to `0.2.10`), and `xgrammar==0.2.8` (pinned to `0.1.21`). 2. **Missing transitive dependencies:** New dependencies required by `vllm==0.32.0` (such as `flashinfer-python==0.7.0.post1`, `apache-tvm-ffi==0.1.11`, `anthropic>=0.71.0`, `mcp>=2.0.0,<3.0.0`, `torchcodec>=0.14`, etc.) are absent from this file. 3. **Out of sync with `sdks/python/setup.py`:** Per the header of this file, updates should be made in `sdks/python/setup.py` (which still pins `vllm==0.10.1.1`, `openai==1.107.1`, and `torch<2.12.0`) and regenerated using `./gradlew :sdks:python:container:generatePythonRequirementsAll`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
