github-actions[bot] commented on code in PR #40863: URL: https://github.com/apache/beam/pull/40863#discussion_r4420027186
########## sdks/python/apache_beam/yaml/integration_tests_test.py: ########## @@ -0,0 +1,80 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import contextlib +import unittest +from unittest.mock import MagicMock +from unittest.mock import Mock +from unittest.mock import patch + +try: + from apache_beam.io.gcp.internal.clients import bigquery + from apache_beam.yaml import integration_tests +except ImportError as exc: + raise unittest.SkipTest(f"BigQuery dependencies not installed: {exc}") Review Comment: **🟢 Low**: `apache_beam.yaml.integration_tests` has unconditional top-level imports for several non-BigQuery optional dependencies (such as `psycopg2`, `pytds`, `sqlalchemy`, `google.cloud.bigtable`, and `testcontainers`). If any of those packages are missing in an environment that only has GCP/BigQuery dependencies installed, the `ImportError` message here (`"BigQuery dependencies not installed: ..."`) can be misleading. ```suggestion raise unittest.SkipTest(f"Integration test dependencies not installed: {exc}") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
