acrites commented on code in PR #40951:
URL: https://github.com/apache/beam/pull/40951#discussion_r4448872692
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingKeyedWorkItemSideInputParDoFn.java:
##########
@@ -169,13 +169,15 @@ public void processElement(Object untypedElem) throws
Exception {
public void processTimers() throws Exception {
// Note: We need to get windowCoder to decode the timers. If we haven't
already deserialized
- // the fnInfo, we peek at a new instance to retrieve that. If this extra
deserialization becomes
- // excessively costly, we could either (1) have the DoFnInstanceManager
remember the associated
- // windowCoder (allowing us to get it without a DoFnInfo instance) or (2)
check whether timers
- // exist without actually decoding them.
+ // the activeFnInfo, we peek at a new instance to retrieve that. If this
extra deserialization
+ // becomes excessively costly, we could either (1) have the
DoFnInstanceManager remember the
+ // associated windowCoder (allowing us to get it without a DoFnInfo
instance) or (2) check
+ // whether timers exist without actually decoding them.
Coder<BoundedWindow> windowCoder =
(Coder<BoundedWindow>)
- (helpers.fnInfo != null ? helpers.fnInfo :
helpers.doFnInstanceManager.peek())
+ (helpers.activeFnInfo != null
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
