scwhittle commented on PR #40956: URL: https://github.com/apache/beam/pull/40956#issuecomment-6604233411
I don't think that this would actually trigger in the common truncation case because we would not used the cached objects due to non-advancing work token, see ReaderCache.acquireReader and WindmillStateCache.ForKey.updateTokens. But it seems better to clean it up where we detect the error than wait for or rely on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
