nielsbasjes commented on a change in pull request #12837: URL: https://github.com/apache/beam/pull/12837#discussion_r502321007
########## File path: website/www/site/content/en/contribute/_index.md ########## @@ -94,6 +94,11 @@ $ go get github.com/linkedin/goavro gLinux users should configure their machines for sudoless Docker. +Alternatively, you can use the [Dockerfile](https://github.com/apache/beam/blob/master/Dockerfile) to setup a container meeting the requirements above, and mounting the directory that contains the Beam repo to the container. e.g.: +```shell script +docker run -it --mount type=bind,source=/Users/jsmith/Desktop/beam,target=/workspaces/beam <CONTAINER_ID> bash +``` Review comment: This /var/run/docker.sock trick seems like something other projects would like also. I do wonder how portable this is. I expect this to work under Linux. But how does that work on a Mac or even something like Windows? I also wonder is this will work on all Linux systems. For one I have read that CentOS 8 no longer installs docker in favor of Podman/Buildah (but there is a podman-docker package so you can still have the same commands). Looking at this effort I propose to have multiple goals to achieve: 1. Have the docker image that can do "most" of the build (i.e. skip the parts that need docker). Seems like this is already there now. 1. Include the script I mentioned so developers can already use this for a lot of the work. Should be an easy addition. 1. Figure out how to run docker commands inside this environment and add that as a later enhancement. I expect this to be a major additional effort because of the variations in underlying implementations. A first version can simply be `if /var/run/docker.sock then "enable this" else "simply don't" ` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
