stankiewicz opened a new pull request, #41011:
URL: https://github.com/apache/beam/pull/41011
* [SolaceIO] Route persistent write ACKs to the owning bundle
Concurrent SolaceIO.Write bundles share pooled JCSMP sessions on a worker.
Because publish results were queued per session rather than per bundle, one
bundle could drain and emit another bundle's ACK during finishBundle, leaving
the owning bundle to time out waiting for a result that had already been
removed.
Give each bundle its own publish-results queue and pass that queue inside
the JCSMP message correlation key so the callback handler delivers ACKs and
NACKs directly to the bundle that published the message. Track in-flight
message IDs with a multiset so duplicate IDs in a single bundle wait for all
publications.
Fixes #40984
* Remove unused Solace correlation key helpers and address review
Unused message creation helpers in UnboundedSolaceWriter still set the
legacy correlation key format rejected by PublishResultHandler. Remove those
helpers, deprecate Solace.CorrelationKey, mark correlation key messageId as
nullable, and ensure test teardown runs even if executor termination fails.
<!--
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
- [ ] Replace these instructions with a description of your change and why
you have made it.
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123` or `fixes #456`).
- [ ] Update `CHANGES.md` with noteworthy changes.
See [CONTRIBUTING.md]() for more details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
