ahmedabu98 commented on code in PR #40982:
URL: https://github.com/apache/beam/pull/40982#discussion_r4483488494
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/BeamSqlTable.java:
##########
@@ -92,4 +92,16 @@ default BeamSqlTable forWrite(Map<String, Object> options) {
throw new UnsupportedOperationException(
String.format("%s does not support WITH options for writes",
getClass().getSimpleName()));
}
+
+ /**
+ * Returns the table to read for one {@code CHANGES(...)} call in FROM, such
as {@code SELECT *
+ * FROM CHANGES(t, 5, 10)}: the changes committed in the {@code changes}
range, read with the
+ * {@code WITH} options, if any. Everything in {@link #forRead} applies here
too.
+ *
+ * @throws UnsupportedOperationException if this table does not support
{@code CHANGES(...)}
Review Comment:
I added rules for out-of-range bounds to the `forChanges` Javadoc, and
updated the Iceberg CDC read to follow them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
