acrites opened a new pull request, #41023: URL: https://github.com/apache/beam/pull/41023
These changes were all fairly small, so keeping in one PR. Summary of Changes GroupIntoBatches.java * Parameter validation: Replaced `Preconditions.checkState` with `checkArgument` and descriptive error messages when `batchSize` or `batchSizeBytes` is `>= Long.MAX_VALUE` in `ofSize`, `withSize`, and both `withByteSize` overloads (and removed the now-unused Preconditions import). * Display data: Implemented `populateDisplayData` on `GroupIntoBatches` and `WithShardedKey` to record configured batchSize, batchSizeBytes, and maxBufferingDuration. * Empty-batch flush guard: Guarded the pre-add byte-size flush check in processElement with `storedBatchSizeBytes.read() > 0` so an element whose weight exceeds batchSizeBytes on an empty batch does not trigger an unnecessary empty flush. * Timestamp overflow guard: Clamped windowEnd to `BoundedWindow.TIMESTAMP_MAX_VALUE` in processElement when `window.maxTimestamp().plus(allowedLateness)` would overflow (e.g., global windows with non-zero allowed lateness?). * Javadoc & cleanup: Fixed mismatched braces and @code tags in the class Javadoc ParDo.of(...) example (lines 77–88) and removed the stray semicolon after `ByteSizeObserver`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
