github-actions[bot] commented on code in PR #41003:
URL: https://github.com/apache/beam/pull/41003#discussion_r4474199861
##########
sdks/python/apache_beam/internal/code_object_pickler_test.py:
##########
@@ -247,6 +260,16 @@ def
test_invalid_lambda_with_hash_path_raises_exception(self):
"apache_beam.internal.test_data.module_3."
"my_function.__code__.co_consts[<lambda>, ('',), 1234567890]")
+ def test_lambda_search_skips_attributes_that_raise(self):
+ fn = ClassWithLambdaAndRaisingAttribute.fn
+ path = code_object_pickler.get_code_object_identifier(fn)
+ self.assertEqual(
Review Comment:
**🟢 Low**: Since `ClassWithLambdaAndRaisingAttribute` is defined in this
test module, `fn.__module__` will be `'__main__'` if the test file is executed
directly via `python code_object_pickler_test.py`. Using `f"{prefix}."`
(defined at line 141 as `prefix = __name__`) keeps this consistent with
`test_cases` above.
```suggestion
f"{prefix}."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
