damccorm commented on code in PR #40985:
URL: https://github.com/apache/beam/pull/40985#discussion_r4471460640
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/PublishResultHandler.java:
##########
@@ -60,16 +78,18 @@ public void responseReceivedEx(Object key) {
}
private void processKey(Object key, boolean isPublished, @Nullable
JCSMPException cause) {
+ if (!(key instanceof PublishCorrelationKey)) {
Review Comment:
Nit: `UnboundedSolaceWriter#createSingleMessage` and `createMessagesArray`
(lines 277–334) are unused and still set the correlation key to
`Solace.CorrelationKey` or a raw `String`, which
`PublishResultHandler#processKey` now rejects and drops. Since
`MessageProducerUtils` already handles message creation, can we remove these
unused methods from `UnboundedSolaceWriter` (and optionally mark
`Solace.CorrelationKey` `@Deprecated` since it is no longer used)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
