github-actions[bot] commented on code in PR #41030:
URL: https://github.com/apache/beam/pull/41030#discussion_r4489009092
##########
buildSrc/build.gradle.kts:
##########
@@ -68,7 +68,7 @@ dependencies {
runtimeOnly("com.google.protobuf:protobuf-gradle-plugin:0.8.13")
// Enable proto code generation
runtimeOnly("com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1")
// Enable Avro code generation. Version 1.1.0 is
the last supporting avro 1.10.2
- runtimeOnly("com.diffplug.spotless:spotless-plugin-gradle:7.2.1")
// Enable a code formatting plugin
+ runtimeOnly("com.diffplug.spotless:spotless-plugin-gradle:8.11.0")
// Enable a code formatting plugin
runtimeOnly("gradle.plugin.com.dorongold.plugins:task-tree:1.5")
// Adds a 'taskTree' task to print task dependency
tree
runtimeOnly("net.linguica.gradle:maven-settings-plugin:0.5")
Review Comment:
**🔴 Critical**: Upgrading `spotless-plugin-gradle` to `8.11.0` breaks the
build with an variant resolution failure because Spotless `8.5.0+` requires
Gradle 9.0 (`org.gradle.plugin.api-version=9.0.0`), while this project uses
Gradle `8.14.3` (`gradle-wrapper.properties`). Additionally, this creates a
version mismatch with `id("com.diffplug.spotless") version "7.2.1"` declared in
the `plugins` block on line 35.
```suggestion
runtimeOnly("com.diffplug.spotless:spotless-plugin-gradle:7.2.1")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
