arunpandianp commented on code in PR #40955:
URL: https://github.com/apache/beam/pull/40955#discussion_r4499390612
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/failures/WorkFailureProcessor.java:
##########
@@ -173,6 +175,17 @@ private RetryEvaluation evaluateRetry(
return RetryEvaluation.RETRY_LOCALLY;
}
+ if (WorkCancellingException.isWorkCancellingException(parsedException)
+ ||
WorkItemCancelledException.isWorkItemCancelledException(parsedException)) {
Review Comment:
Updated to a helper checking both. Want to keep WorkCancellingException and
WorkItemCancelledException separate as code catching them do different things
today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
