damccorm opened a new pull request, #41064:
URL: https://github.com/apache/beam/pull/41064

   ## Summary
   Fixes flaky `DeadlineExceededException` failures in `PostCommit SQL` 
(`PubsubTableProviderIT` and `BeamSqlLineIT`, e.g. 
https://github.com/apache/beam/actions/runs/42312418759, 
https://github.com/apache/beam/actions/runs/41878199992, 
https://github.com/apache/beam/actions/runs/41779718356).
   
   In `com.google.cloud.pubsub.v1`, `TopicAdminClient.createTopic` and 
`SubscriptionAdminClient.createSubscription` have a 60s RPC timeout with no 
default retries configured on `DEADLINE_EXCEEDED` / `UNAVAILABLE`. When a 
single `createSubscription` or `createTopic` RPC in 
`TestPubsub.initializePubsub` or `TestPubsubSignal.initializePubsub` stalls for 
60s against `pubsub.googleapis.com`, the test immediately fails with 
`com.google.api.gax.rpc.DeadlineExceededException`.
   
   This PR adds a 3-attempt retry helper in `TestPubsub` (used by both 
`TestPubsub` and `TestPubsubSignal`, similar to `PubsubResourceManager`) that 
retries `createTopic` and `createSubscription` on `DeadlineExceededException` 
and `UnavailableException` (treating `AlreadyExistsException` on retry as 
success).
   
   ## Verification
   - Triggered `PostCommit SQL` on this branch: 
https://github.com/apache/beam/actions/runs/42317114490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to