damccorm opened a new pull request, #41067: URL: https://github.com/apache/beam/pull/41067
## Summary Fixes a flake in `DicomIOReadIT` (`PreCommit Java GCP IO Direct` run https://github.com/apache/beam/actions/runs/42336715354/job/128295165204): ``` com.google.api.client.googleapis.json.GoogleJsonResponseException: 409 Conflict POST https://healthcare.googleapis.com/v1/projects/apache-beam-testing/locations/us-central1/datasets/apache-beam-integration-testing/dicomStores?dicomStoreId=foo { "code": 409, "message": "already exists", "status": "ALREADY_EXISTS" } at org.apache.beam.sdk.io.gcp.healthcare.HttpHealthcareApiClient.createDicomStore(HttpHealthcareApiClient.java:270) at org.apache.beam.sdk.io.gcp.healthcare.HttpHealthcareApiClient.createDicomStore(HttpHealthcareApiClient.java:225) at org.apache.beam.sdk.io.gcp.healthcare.DicomIOReadIT.setup(DicomIOReadIT.java:55) ``` ### Root Cause Unlike all other Healthcare integration tests (`HL7v2IOReadIT`, `FhirIOReadIT`, etc.), `DicomIOReadIT` hardcoded `storeName = "foo"`, causing concurrent test runs (or runs after a prior aborted test) to collide on `dicomStores?dicomStoreId=foo` with `409 Conflict: already exists`. ### Changes - Generate a unique `storeName` (`"DICOM_store_" + System.currentTimeMillis() + "_" + new SecureRandom().nextInt(32) + "_read_it"`) in `DicomIOReadIT.setup()`, matching `HL7v2IOReadIT` and `FhirIOReadIT`. ## Verification - Triggered `PreCommit Java GCP IO Direct` workflow run on this branch: https://github.com/apache/beam/actions/runs/42341086140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
