jonathansudhakar1 commented on issue #21337:
URL: https://github.com/apache/beam/issues/21337#issuecomment-6724426559
This looks fixed. #16530 ("Adding JSON support in SpannerIO and Spanner
schema parser", merged 2022-01-21, first released in 2.37.0) added `JSON` to
the schema parser, which is the method in the stack trace above. It also added
JSON support to `MutationSizeEstimator` for the write path. That PR landed a
few months before this issue was imported from Jira.
On current master (84a02fe905c):
- `SpannerSchema.Column.parseSpannerType` maps `JSON` to `Type.json()`
([SpannerSchema.java#L178](https://github.com/apache/beam/blob/84a02fe905c/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchema.java#L178)).
PostgreSQL `JSONB` has been handled too since #29313.
-
[`SpannerSchemaTest.testSingleTable`](https://github.com/apache/beam/blob/84a02fe905c/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchemaTest.java#L40)
adds a `JSON` column through `SpannerSchema.builder().addColumn(...)` and
asserts `Type.json()`.
I ran `./gradlew :sdks:java:io:google-cloud-platform:test --tests
'*.spanner.SpannerSchemaTest' --tests '*.spanner.MutationSizeEstimatorTest'` on
that commit: 17 tests, 0 failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
