damccorm commented on code in PR #41066:
URL: https://github.com/apache/beam/pull/41066#discussion_r4513056050
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkRowUpdateIT.java:
##########
@@ -202,21 +202,10 @@ private void assertRowsWritten(String tableSpec,
Iterable<TableRow> expected)
}
private void runPipelineAndWait(Pipeline p) {
+ // Run on a single DirectRunner thread so concurrent bundles do not share
a closed
+ // StreamWriter while the destination table is being created on the first
write retry.
+ p.getOptions().as(DirectOptions.class).setTargetParallelism(1);
Review Comment:
Done — updated `StorageApiWriteUnshardedRecords` (f63c9551031) so
synchronous `StreamWriterClosedException` from `writeStream.appendRows(...)`
returns `ApiFutures.immediateFailedFuture(e)` into `RetryManager`, and
`onError` does not treat `StreamWriterClosedException` (`FAILED_PRECONDITION`)
as a non-retryable persistent error. Also removed the `targetParallelism(1)`
test workarounds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
