damccorm commented on code in PR #41059:
URL: https://github.com/apache/beam/pull/41059#discussion_r4513554348
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1727,7 +1747,7 @@ def _create_table_if_needed(self, table_reference,
schema=None):
def _check_row_size(self, row_and_insert_id) -> tuple[int, Optional[str]]:
"""Returns error string when the row estimated size is too big"""
- row_byte_size = get_deep_size(row_and_insert_id)
+ row_byte_size = _fast_row_and_insert_id_size(row_and_insert_id)
Review Comment:
Fixed in 0f74680ebac: we now re-check with
`get_deep_size(row_and_insert_id)` inside `_check_row_size` when `row_byte_size
>= self._max_insert_payload_size`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
