Tarun4201 commented on PR #41083:
URL: https://github.com/apache/beam/pull/41083#issuecomment-6748390572
### CI Failure Fixes Summary
- **Windows Root-Relative Path Resolution**:
- Fixed `StringCompiler.resolveManifestEntry` on Windows where
root-relative paths starting with `/` or `\` (e.g. `\opt\beam\dep.jar` or
`file:/opt/beam/...`) were incorrectly identified as non-absolute by
`File.isAbsolute()` and resolved against `parentDir`.
- Added `isRootedOrAbsolute()` and `isWindowsAbsoluteDrivePath()` to
strictly distinguish root-relative paths (`/...`, `\...`), UNC paths (`\\...`),
Windows drive-absolute paths (`C:\...`, `C:/...`), and drive-relative paths
(`C:folder`).
- Added URI normalization for Windows drive paths to avoid standard Java
URI syntax dropping drive-letter prefixes.
- **SpotBugs DCN_NULLPOINTER_EXCEPTION Resolution**:
- Replaced `catch (NullPointerException)` with explicit null/empty guards
(`entry == null || entry.isEmpty()`) and narrowed exception handling to
`IllegalArgumentException`.
- **Regression Tests**:
- Added test coverage in `StringCompilerTest` for root-relative paths,
single-backslash Windows paths, drive-absolute paths with slash/backslash, UNC
paths, and drive-relative paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
