Abacn commented on code in PR #41118: URL: https://github.com/apache/beam/pull/41118#discussion_r4517390473
########## buildSrc/settings.gradle.kts: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * License); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +pluginManagement { + val parentProperties = java.util.Properties().apply { + val file = file("../gradle.properties") + if (file.exists()) { + file.inputStream().use { load(it) } + } + } + + val mavenCentralMirrorUrl = parentProperties.getProperty("mavenCentralMirrorUrl") + val isCi = System.getenv("GITHUB_ACTIONS") != null || System.getenv("JENKINS_HOME") != null + val useMirror = isCi && !mavenCentralMirrorUrl.isNullOrBlank() + + if (useMirror) { + logger.debug("Running in CI. Mirroring Maven Central repositories via Google Maven Mirror for buildSrc pluginManagement.") Review Comment: This same logging caused mild log spam on CI. It is printed on every module resolved https://github.com/apache/beam/blob/74f141d193148576cdf2545090ba5dac21d3900a/buildSrc/build.gradle.kts#L41 https://github.com/apache/beam/blob/74f141d193148576cdf2545090ba5dac21d3900a/settings.gradle.kts#L26 https://github.com/apache/beam/blob/74f141d193148576cdf2545090ba5dac21d3900a/buildSrc/src/main/groovy/org/apache/beam/gradle/Repositories.groovy#L30 If possible we can just preserve one log line (and remove three others) thus make it print once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
